Skip to content

LPC1768 Watchdog & Reset Reason #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2019
Merged

LPC1768 Watchdog & Reset Reason #11226

merged 4 commits into from
Aug 20, 2019

Conversation

chrissnow
Copy link
Contributor

Description

Implements Watchdog & Reset Reason for LPC1768 targets.

image
image
image

image

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and a team August 14, 2019 17:00
@ciarmcom
Copy link
Member

@chrissnow, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 requested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License fix

targets/TARGET_NXP/TARGET_LPC176X/reset_reason.c Outdated
@@ -0,0 +1,62 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2017 ARM Limited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files, 2019 year. Can you also use SPDX idenfier? Check platform files for the proper license

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 191f029 into ARMmbed:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.13.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrissnow @ciarmcom @0xc0170 @mbed-ci